Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shop legal details to template #43

Merged
merged 4 commits into from
Jan 10, 2022
Merged

Conversation

Hlavtox
Copy link
Contributor

@Hlavtox Hlavtox commented Nov 30, 2021

Questions Answers
Description? Legal information is not displayed on contact page, while there is a field for that in Prestashop settings.
Type? improvement
BC breaks? no
Deprecations? no
Fixed ticket? Fixes PrestaShop/PrestaShop#26809
How to test? You need to test without an overriding TPL in /themes/classic/modules/ps_contactinfo.

PierreRambaud
PierreRambaud previously approved these changes Nov 30, 2021
@PierreRambaud PierreRambaud changed the base branch from master to dev November 30, 2021 15:03
@PierreRambaud PierreRambaud dismissed their stale review November 30, 2021 15:03

The base branch was changed.

@PierreRambaud
Copy link
Contributor

Could you please rebase your PR?

@Hlavtox
Copy link
Contributor Author

Hlavtox commented Nov 30, 2021

@PierreRambaud Should be good now, sorry

PierreRambaud
PierreRambaud previously approved these changes Nov 30, 2021
@florine2623
Copy link
Contributor

Hello @Hlavtox ,

Thanks for the PR !

I have a question about the test.

  • I have installed the PR
  • Commented all files in /themes/classic/modules/ps_contactinfo to avoid overrides
  • I don't have the correct visual

Without PR :
Screenshot 2021-12-01 at 14 08 24

With PR :
Screenshot 2021-12-01 at 14 07 15

Am I missing something ?
Thanks!

@Hlavtox
Copy link
Contributor Author

Hlavtox commented Dec 1, 2021

Hi, made a mistake, should work now. :-)

PierreRambaud
PierreRambaud previously approved these changes Dec 1, 2021
@florine2623
Copy link
Contributor

Hello @Hlavtox 👋 ,

I have commented _ps_contactinfo.tpl and _ps_contactinfo-rich.tpl files from /themes/classic/modules/ps_contactinfo.

Here's my result :
Screenshot 2021-12-02 at 11 54 37

  • I have 2 fields for email, I should only have 1. I have his feature is enabled automatically from module ps_contactinfo :

Screenshot 2021-12-02 at 11 56 05

  • Also the line break isn't taking into account. Would it be possible to add it so reading of the info can be easier ?

Thank you !!

@Hlavtox
Copy link
Contributor Author

Hlavtox commented Dec 21, 2021

@florine2623 Hi! :-) Duplicate email removed and added line breaks. 👍

Výstřižek

@florine2623
Copy link
Contributor

Hello @Hlavtox !

I encounter an error on the FO after installing the PR :/
Even after commenting the files in /themes/classic/modules/ps_contactinfo to avoid overrides :
Screenshot 2021-12-22 at 09 31 31

Is there something I am missing ? 😄
Thanks!

@Hlavtox
Copy link
Contributor Author

Hlavtox commented Jan 5, 2022

@florine2623 That's not the scope of this PR, I will fix in another PR. :-)

@florine2623
Copy link
Contributor

Hello @Hlavtox ,

Thanks for the update, works like a charm :)
It is QA ✅

@PierreRambaud
Copy link
Contributor

Thank you @Hlavtox

@PierreRambaud PierreRambaud added this to the 3.3.1 milestone Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Legal info is not displayed in contact module
4 participants